Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding additional tests to repo #118

Merged
merged 28 commits into from
Jun 10, 2021
Merged

Adding additional tests to repo #118

merged 28 commits into from
Jun 10, 2021

Conversation

Eo300
Copy link
Collaborator

@Eo300 Eo300 commented Jun 7, 2021 •
edited
Loading

This relates to #94
Adding some tests which use the moto package. This is mainly for progress in order to get some tests into main. As such, don't delete this branch after merge.

pytest is run from the top directory

Possible next step is to parameterize the variable

Eo300 added 16 commits May 14, 2021 18:02
@Eo300
Add job-info-retrieval test + placeholder tests
7b9f169
@Eo300
Some pseudocode for test implementation
1c673dc
@Eo300
Add pytest fixtures to initialize buckets/queues
50ec602
@Eo300
Create test for upload_status_file()
d3fba1d
@Eo300
Add SQS region to Job Service environment vars
d531aec
@Eo300
Add PDB2PQR test for Job Service lambda handler
6cfa436
@Eo300
Missing newlines
ff33f54
@Eo300
Update requirements-dev.txt
1040992 
'docker' package required for mock_sqs
@Eo300
Formatting via black
b7da8b1
@Eo300
Add test for invalid job handler
ae2b291
@Eo300
Format test_job_service.py via black
af432b7
@Eo300
Add "date" to expected values in API Service test
ca038ee
@Eo300
Add test for successful direct APBS job
8cb9325
@Eo300
Merge branch 'main' of https://github.com/Electrostatics/apbs-aws int…
68c9f58 
…o Eo300/issue_94
@Eo300
Add missing job_tags
1cb3aee
@Eo300
Added additional development packages
a899668
@Eo300 Eo300 added the core Required to build base system label Jun 7, 2021
@Eo300 Eo300 requested review from mmacduff and intendo June 7, 2021 22:24
@Eo300
Copy link
Collaborator Author

Eo300 commented Jun 9, 2021

Current coverage:

Name                                                     Stmts   Miss  Cover
----------------------------------------------------------------------------
lambda_services\api_service\__init__.py                      0      0   100%
lambda_services\api_service\api_service.py                  38      2    95%
lambda_services\job_service\__init__.py                      0      0   100%
lambda_services\job_service\job_service.py                  88     12    86%
lambda_services\job_service\launcher\apbs_runner.py        212     64    70%
lambda_services\job_service\launcher\jobsetup.py            37     12    68%
lambda_services\job_service\launcher\pdb2pqr_runner.py      69     24    65%
lambda_services\job_service\launcher\utils.py              166     48    71%
lambda_services\job_service\launcher\weboptions.py         130     57    56%
----------------------------------------------------------------------------
TOTAL                                                      740    219    70%

intendo
intendo approved these changes Jun 9, 2021
View reviewed changes
Copy link
Contributor

@intendo intendo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Eo300 I added empty blank lines at the end of a few files so that Github won't complain about them.

intendo and others added 2 commits June 10, 2021 14:23
@intendo intendo merged commit 6ed79e3 into main Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmacduff mmacduff mmacduff approved these changes

@intendo intendo intendo approved these changes

Assignees
No one assigned
Labels
core Required to build base system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Eo300 @mmacduff @intendo